Bytes: Fix length from fromBytes on JS#2025
Merged
joshtynjala merged 4 commits intoopenfl:developfrom Feb 6, 2026
Merged
Conversation
Contributor
I also got 16 in Firefox on Linux. |
Contributor
Author
|
I also added a fix to haxe, but lime should probably account for this on older versions |
tobil4sk
reviewed
Jan 26, 2026
joshtynjala
added a commit
to openfl/openfl
that referenced
this pull request
Feb 6, 2026
It turns out that the underlying ArrayBuffer might be longer than the ByteArray, so make a copy in that case because TextDecoder strictly reads the entire ArrayBuffer (references openfl/lime#2025). Followup to commit dcf3f11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially related to: openfl/openfl#2360
In JS the underlying byte data may have extras, due to the underlying types used in js, explained here: HaxeFoundation/haxe#8974. This pr will ignore those extras.
Example reproducing the inconsistent behavior:
Tested on chrome for mac